Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support tf2.16.2 #462

Merged
merged 2 commits into from
Sep 17, 2024
Merged

support tf2.16.2 #462

merged 2 commits into from
Sep 17, 2024

Conversation

jq
Copy link
Collaborator

@jq jq commented Sep 9, 2024

Description

build, test, and release for tf 2.16.2, co-work with @poinwater

Fixes # (issue)

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@jq jq force-pushed the tf2.16.2 branch 22 times, most recently from bc44f72 to 660b122 Compare September 10, 2024 02:44
@jq jq requested a review from rhdong as a code owner September 10, 2024 02:44
@jq jq force-pushed the tf2.16.2 branch 2 times, most recently from d418ebb to dddd38b Compare September 10, 2024 04:09
@jq jq force-pushed the tf2.16.2 branch 4 times, most recently from c201e8f to 1959b17 Compare September 10, 2024 16:40
@jq jq force-pushed the tf2.16.2 branch 24 times, most recently from 574911e to 452726e Compare September 13, 2024 04:01
rhdong
rhdong approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong requested a review from MoFHeka September 13, 2024 20:52
@rhdong
Copy link
Member

rhdong commented Sep 13, 2024

Hey @MoFHeka, could you have time to help review the Keras part? Many thanks!

@rhdong rhdong merged commit 87b29aa into tensorflow:master Sep 17, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhdong rhdong rhdong approved these changes

@MoFHeka MoFHeka Awaiting requested review from MoFHeka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jq @rhdong